Skip to content

fix(client): generate update id client-side when not provided#773

Merged
xepozz merged 1 commit into
masterfrom
fix/577-client-side-update-id
Jul 13, 2026
Merged

fix(client): generate update id client-side when not provided#773
xepozz merged 1 commit into
masterfrom
fix/577-client-side-update-id

Conversation

@xepozz

@xepozz xepozz commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

What was changed

  • Adds a functional regression test that runs an update against the time-skipping test server (WithoutTimeSkipping).
  • Client-side UUID generation

Why?

Generate the id client-side via Common\Uuid::v4() when the caller did not supply one, matching sdk-go, sdk-java and sdk-typescript.

Checklist

  1. Closes [Bug] Can't run the tests of UpdateMethod #577

  2. How was this tested:

  1. Any docs updates needed?

WorkflowStub::startUpdate() sent an empty update id and relied on the
Temporal frontend to assign one. The frontend does; the Java time-skipping
test server does not — the empty id reaches the worker, which panics
("update id is empty, can't validate update"), failing the update workflow
task in a retry loop and wedging the whole execution. The update result
never returns and subsequent signals stop being processed (issue #577).

Generate the id client-side via Common\Uuid::v4() when the caller did not
supply one, matching sdk-go, sdk-java and sdk-typescript.

Adds a functional regression test that runs an update against the
time-skipping test server (WithoutTimeSkipping).

Closes #577
@xepozz
xepozz requested review from a team, roxblnfk and wolfy-j as code owners July 10, 2026 09:34
@xepozz
xepozz merged commit 71067c4 into master Jul 13, 2026
259 of 261 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Can't run the tests of UpdateMethod

2 participants